From a39640687745f5f6584d48dd8a185bfea0c890a9 Mon Sep 17 00:00:00 2001
From: "Daniele Verducci (Slimpenguin)" <daniele.verducci@gmail.com>
Date: Mon, 19 Feb 2024 08:26:55 +0100
Subject: [PATCH] Resolved warnings on main activity layout

---
 app/src/main/res/layout/activity_list_view.xml | 15 ++++++++++-----
 app/src/main/res/values-it/strings.xml         |  5 +++++
 app/src/main/res/values/strings.xml            |  5 +++++
 app/src/main/res/values/styles.xml             |  1 -
 4 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/app/src/main/res/layout/activity_list_view.xml b/app/src/main/res/layout/activity_list_view.xml
index b8c5766..94451c0 100644
--- a/app/src/main/res/layout/activity_list_view.xml
+++ b/app/src/main/res/layout/activity_list_view.xml
@@ -84,7 +84,8 @@
                         android:paddingEnd="@dimen/spacer_1x"
                         android:paddingBottom="@dimen/spacer_2x"
                         android:tint="@color/text_color"
-                        android:src="@drawable/ic_menu_grey"/>
+                        android:src="@drawable/ic_menu_grey"
+                        android:contentDescription="@string/menu"/>
                     <androidx.appcompat.widget.AppCompatTextView
                         android:id="@+id/search_text"
                         android:layout_width="0dp"
@@ -110,7 +111,8 @@
         android:id="@+id/fragment_container"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
-        android:name="it.danieleverducci.nextcloudmaps.fragments.GeofavoriteListFragment" />
+        android:name="it.danieleverducci.nextcloudmaps.fragments.GeofavoriteListFragment"
+        tools:layout="@layout/fragment_geofavorite_list" />
 
 
     <!-- Add from map FAB -->
@@ -124,7 +126,8 @@
         app:backgroundTint="@color/defaultBrand"
         app:fabSize="mini"
         app:tint="@color/white"
-        tools:ignore="DuplicateClickableBoundsCheck" />
+        tools:ignore="DuplicateClickableBoundsCheck"
+        android:contentDescription="@string/add_from_map" />
 
     <!-- Add from current position FAB -->
     <com.google.android.material.floatingactionbutton.FloatingActionButton
@@ -136,7 +139,8 @@
         app:fabSize="mini"
         android:src="@drawable/ic_add_gps"
         app:backgroundTint="@color/defaultBrand"
-        app:tint="@color/white"/>
+        app:tint="@color/white"
+        android:contentDescription="@string/add_from_gps"/>
 
     <!-- Main FAB -->
     <com.google.android.material.floatingactionbutton.FloatingActionButton
@@ -147,6 +151,7 @@
         android:layout_height="wrap_content"
         android:src="@drawable/ic_add"
         app:backgroundTint="@color/defaultBrand"
-        app:tint="@color/white"/>
+        app:tint="@color/white"
+        android:contentDescription="@string/open_fab"/>
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
\ No newline at end of file
diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml
index cff9a01..ddc7f34 100644
--- a/app/src/main/res/values-it/strings.xml
+++ b/app/src/main/res/values-it/strings.xml
@@ -97,4 +97,9 @@
     <string name="new_geobookmark_gps">Crea dalla posizione corrente</string>
     <string name="new_geobookmark_map">Crea dalla mappa</string>
 
+    <!-- Accessibility (content descriptions) -->
+    <string name="open_fab">Aggiungi</string>
+    <string name="add_from_gps">Crea dalla posizione corrente</string>
+    <string name="add_from_map">Crea dalla mappa</string>
+
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 9eee611..0590311 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -96,4 +96,9 @@
     <string name="new_geobookmark_gps">New from current position</string>
     <string name="new_geobookmark_map">New from map</string>
 
+    <!-- Accessibility (content descriptions) -->
+    <string name="open_fab">Add geofavorite</string>
+    <string name="add_from_gps">Add geofavorite at current GPS position</string>
+    <string name="add_from_map">Add geofavorite from map</string>
+    <string name="menu">Open menu</string>
 </resources>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index e5b3f1a..6893995 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -17,7 +17,6 @@
 
 <resources>
     <!-- Base application theme. -->
-    <!--<style name="BaseTheme" parent="Theme.AppCompat.DayNight.NoActionBar">-->
     <style name="BaseTheme" parent="Theme.MaterialComponents.DayNight.NoActionBar">
         <item name="colorAccent">@color/defaultBrand</item>
         <item name="colorControlNormal">?attr/colorAccent</item>