Add option to force Google Maps or use geo: URI for navigation #1

2026-07-07T12:55:12+02:00

sim6 commented

2026-07-07 12:55:12 +02:00

When user have Google Maps installed, also when user have it disabled, cannot open geolocations with other app.

With this new setting, if an user do not want to open always the geolocations with Google Map can disable it via a settings option.

Closes https://github.com/penguin86/nextcloud-maps-client/issues/17

When user have Google Maps installed, also when user have it disabled, cannot open geolocations with other app. With this new setting, if an user do not want to open always the geolocations with Google Map can disable it via a settings option. Closes https://github.com/penguin86/nextcloud-maps-client/issues/17

sim6 requested review from penguin86 2026-07-07 12:55:12 +02:00

sim6 added 2 commits 2026-07-07 14:45:30 +02:00

Add option to force Google Maps or use geo: URI for navigation 096cb18415

Remove Google Maps installed check from navigation f0d8e30d39

sim6 force-pushed no-google-maps from 2ff66d46db to f0d8e30d39

2026-07-07 14:45:30 +02:00

Compare

sim6 commented

2026-07-07 14:47:01 +02:00

I added an explanation in settings option.

penguin86 commented

2026-07-07 23:41:14 +02:00

Hello Simo, thanks for the PR!
I'd like to propose a change. I fear the default for the setting (enabled) is not very sensible: on my degoogled phone, after installing the app, the geofavorites are opened in google maps' webpage. This is a little inconvenient, as the user may not realize why it is happening. I'd wire the preexistent google maps check to the settings default, like:

    public static boolean isUseGoogleMaps(Context context) {
        return PreferenceManager.getDefaultSharedPreferences(context)
                .getBoolean(SETTING_USE_GOOGLE_MAPS, isGoogleMapsInstalled(context));
    }

(pseudocode).
This way, on Google phones the default for the setting is enabled, while on degoogled ones the default is to provide a valid geouri.
Thank you!

Hello Simo, thanks for the PR! I'd like to propose a change. I fear the default for the setting (enabled) is not very sensible: on my degoogled phone, after installing the app, the geofavorites are opened in google maps' webpage. This is a little inconvenient, as the user may not realize why it is happening. I'd wire the preexistent google maps check to the settings default, like: ``` public static boolean isUseGoogleMaps(Context context) { return PreferenceManager.getDefaultSharedPreferences(context) .getBoolean(SETTING_USE_GOOGLE_MAPS, isGoogleMapsInstalled(context)); } ``` (pseudocode). This way, on Google phones the default for the setting is enabled, while on degoogled ones the default is to provide a valid geouri. Thank you!

sim6 commented

2026-07-08 09:17:32 +02:00

Thanks! Most users can open Google Maps from the Geo URI and set it as default if they want. Since the setting is for a small number of devices that do not open Google Maps from the Geo URI and need to be forced to open it via Google Maps. What is your opinion about changing the default setting to disabled?

penguin86 merged commit 46da74fa89 into develop

2026-07-16 10:45:25 +02:00

sim6 commented

2026-07-16 11:00:21 +02:00

Ops, you merged it without changing the default setting to disabled.

penguin86 commented

2026-07-16 11:28:39 +02:00

Hey Simo,
no worries, I changed it on the develop branch after the merge, working a little on the app!
Thank you for your contribution! May I add your name to a "contributors" section on the README? How whould you like to appear? (username, fullname, email...)

Hey Simo, no worries, I changed it on the develop branch after the merge, working a little on the app! Thank you for your contribution! May I add your name to a "contributors" section on the README? How whould you like to appear? (username, fullname, email...)

sim6 commented

2026-07-16 12:10:28 +02:00

My full name is fine, if you want you can also add the email address. I do not like the final solution because if a user have a regular Android that comes with Google Maps but user disabled it the default setting is enabled. Anyway, thank you very much.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: penguin86/nextcloud-maps-client#1

Allow edits from maintainers