Reimplemented API Provider

To try to fix NullPointerException on mApi reported in Play Store

app/src/main/java/it/danieleverducci/nextcloudmaps/activity/detail/GeofavoriteDetailActivity.java

@@ -119,7 +119,7 @@ public class GeofavoriteDetailActivity extends NextcloudMapsStyledActivity imple
         });
 
         mViewModel = new ViewModelProvider(this).get(GeofavoriteDetailActivityViewModel.class);
-        mViewModel.init();
+        mViewModel.init(getApplicationContext());
         mViewModel.getCategories().observe(this, new Observer<HashSet<String>>() {
             @Override
             public void onChanged(HashSet<String> categories) {

app/src/main/java/it/danieleverducci/nextcloudmaps/activity/detail/GeofavoriteDetailActivityViewModel.java

@@ -1,5 +1,7 @@
 package it.danieleverducci.nextcloudmaps.activity.detail;
 
+import android.content.Context;
+
 import androidx.lifecycle.LiveData;
 import androidx.lifecycle.MutableLiveData;
 import androidx.lifecycle.ViewModel;
@@ -14,8 +16,8 @@ import it.danieleverducci.nextcloudmaps.repository.GeofavoriteRepository;
 public class GeofavoriteDetailActivityViewModel extends ViewModel {
     private GeofavoriteRepository mRepo;
 
-    public void init() {
-        mRepo = GeofavoriteRepository.getInstance();
+    public void init(Context applicationContext) {
+        mRepo = GeofavoriteRepository.getInstance(applicationContext);
     }
 
     public Geofavorite getGeofavorite(int id) {

app/src/main/java/it/danieleverducci/nextcloudmaps/activity/login/LoginActivity.java

@@ -41,11 +41,11 @@ import com.nextcloud.android.sso.ui.UiExceptionManager;
 import it.danieleverducci.nextcloudmaps.R;
 import it.danieleverducci.nextcloudmaps.activity.NextcloudMapsStyledActivity;
 import it.danieleverducci.nextcloudmaps.activity.main.MainActivity;
+import it.danieleverducci.nextcloudmaps.api.API;
 import it.danieleverducci.nextcloudmaps.api.ApiProvider;
 
 public class LoginActivity extends NextcloudMapsStyledActivity {
 
-    protected ApiProvider mApi;
     protected ProgressBar progress;
     protected Button button;
 
@@ -115,9 +115,6 @@ public class LoginActivity extends NextcloudMapsStyledActivity {
     }
 
     private void accountAccessDone() {
-        Context l_context = getApplicationContext();
-        mApi = new ApiProvider(l_context);
-
         Intent intent = new Intent(LoginActivity.this, MainActivity.class);
         startActivity(intent);
 

app/src/main/java/it/danieleverducci/nextcloudmaps/activity/main/MainActivity.java

@@ -58,6 +58,7 @@ import it.danieleverducci.nextcloudmaps.activity.login.LoginActivity;
 import it.danieleverducci.nextcloudmaps.activity.main.NavigationAdapter.NavigationItem;
 import it.danieleverducci.nextcloudmaps.activity.main.SortingOrderDialogFragment.OnSortingOrderListener;
 import it.danieleverducci.nextcloudmaps.activity.mappicker.MapPickerActivity;
+import it.danieleverducci.nextcloudmaps.api.ApiProvider;
 import it.danieleverducci.nextcloudmaps.model.Geofavorite;
 import it.danieleverducci.nextcloudmaps.utils.GeoUriParser;
 import it.danieleverducci.nextcloudmaps.utils.IntentGenerator;
@@ -140,7 +141,7 @@ public class MainActivity extends NextcloudMapsStyledActivity implements OnSorti
 
 
         mMainActivityViewModel = new ViewModelProvider(this).get(MainActivityViewModel.class);
-        mMainActivityViewModel.init();
+        mMainActivityViewModel.init(getApplicationContext());
         mMainActivityViewModel.getIsUpdating().observe(this, new Observer<Boolean>() {
             @Override
             public void onChanged(@Nullable Boolean aBoolean) {
@@ -155,7 +156,7 @@ public class MainActivity extends NextcloudMapsStyledActivity implements OnSorti
         mMainActivityViewModel.getOnFinished().observe(this, new Observer<Boolean>() {
             @Override
             public void onChanged(@Nullable Boolean success) {
-                if(!success){
+                if(success == null || !success){
                     Toast.makeText(MainActivity.this, R.string.list_geofavorite_connection_error, Toast.LENGTH_LONG).show();
                 }
             }
@@ -297,9 +298,11 @@ public class MainActivity extends NextcloudMapsStyledActivity implements OnSorti
     }
 
     private void switch_account() {
+        ApiProvider.logout();
         SingleAccountHelper.setCurrentAccount(this, null);
         Intent intent = new Intent(MainActivity.this, LoginActivity.class);
         startActivity(intent);
+        finish();
     }
 
     @Override

app/src/main/java/it/danieleverducci/nextcloudmaps/activity/main/MainActivityViewModel.java

@@ -1,5 +1,7 @@
 package it.danieleverducci.nextcloudmaps.activity.main;
 
+import android.content.Context;
+
 import androidx.lifecycle.LiveData;
 import androidx.lifecycle.MutableLiveData;
 import androidx.lifecycle.ViewModel;
@@ -12,8 +14,8 @@ import it.danieleverducci.nextcloudmaps.repository.GeofavoriteRepository;
 public class MainActivityViewModel extends ViewModel {
     private GeofavoriteRepository mRepo;
 
-    public void init() {
-        mRepo = GeofavoriteRepository.getInstance();
+    public void init(Context applicationContext) {
+        mRepo = GeofavoriteRepository.getInstance(applicationContext);
     }
 
     public LiveData<List<Geofavorite>> getGeofavorites(){