Better error management, check Webdav instance unavailable, fixed crash on refresh when webdav instance was unavailable

app/src/main/java/it/danieleverducci/lunatracker/MainActivity.kt

@@ -1,5 +1,6 @@
 package it.danieleverducci.lunatracker
 
+import android.content.DialogInterface
 import android.content.Intent
 import android.os.Bundle
 import android.os.Handler
@@ -122,7 +123,7 @@ class MainActivity : AppCompatActivity() {
             showSettings()
         })
         findViewById<View>(R.id.button_no_connection_retry).setOnClickListener({
-            loadLogbook(logbook.name)
+            loadLogbookList()
         })
         findViewById<View>(R.id.button_sync).setOnClickListener({
             loadLogbook(logbook.name)
@@ -306,9 +307,11 @@ class MainActivity : AppCompatActivity() {
         )
         dialogView.findViewById<TextView>(R.id.dialog_event_detail_type_notes).setText(event.notes)
         d.setView(dialogView)
-        d.setPositiveButton(android.R.string.ok) { dialogInterface, i -> dialogInterface.dismiss() }
+        d.setPositiveButton(R.string.dialog_event_detail_save_button) { dialogInterface, i -> dialogInterface.dismiss() }
+        d.setNeutralButton(R.string.dialog_event_detail_delete_button) { dialogInterface, i -> deleteEvent(event) }
         val alertDialog = d.create()
         alertDialog.show()
+        alertDialog.getButton(DialogInterface.BUTTON_NEUTRAL).setTextColor(ContextCompat.getColor(this, R.color.danger))
     }
 
     fun showAddLogbookDialog(requestedByUser: Boolean) {
@@ -372,15 +375,35 @@ class MainActivity : AppCompatActivity() {
             }
 
             override fun onIOError(error: IOException) {
-                TODO("Not yet implemented")
+                Log.e(TAG, "Unable to load logbooks list (IOError): $error")
+                runOnUiThread({
+                    setLoading(false)
+                    onRepoError(getString(R.string.settings_network_error) + error.toString())
+                })
             }
 
             override fun onWebDAVError(error: SardineException) {
-                TODO("Not yet implemented")
+                Log.e(TAG, "Unable to load logbooks list (SardineException): $error")
+                runOnUiThread({
+                    setLoading(false)
+                    onRepoError(
+                        if(error.toString().contains("401")) {
+                            getString(R.string.settings_webdav_error_denied)
+                        } else if(error.toString().contains("503")) {
+                            getString(R.string.settings_webdav_error_server_offline)
+                        } else {
+                            getString(R.string.settings_webdav_error_generic) + error.toString()
+                        }
+                    )
+                })
             }
 
             override fun onError(error: Exception) {
-                TODO("Not yet implemented")
+                Log.e(TAG, "Unable to load logbooks list: $error")
+                runOnUiThread({
+                    setLoading(false)
+                    onRepoError(getString(R.string.settings_generic_error) + error.toString())
+                })
             }
         })
     }
@@ -409,6 +432,8 @@ class MainActivity : AppCompatActivity() {
                     onRepoError(
                         if(error.toString().contains("401")) {
                             getString(R.string.settings_webdav_error_denied)
+                        } else if(error.toString().contains("503")) {
+                            getString(R.string.settings_webdav_error_server_offline)
                         } else {
                             getString(R.string.settings_webdav_error_generic) + error.toString()
                         }
@@ -472,6 +497,8 @@ class MainActivity : AppCompatActivity() {
                     onRepoError(
                         if(error.toString().contains("401")) {
                             getString(R.string.settings_webdav_error_denied)
+                        } else if(error.toString().contains("503")) {
+                            getString(R.string.settings_webdav_error_server_offline)
                         } else {
                             getString(R.string.settings_webdav_error_generic) + error.toString()
                         }
@@ -520,6 +547,18 @@ class MainActivity : AppCompatActivity() {
         }
     }
 
+    fun deleteEvent(event: LunaEvent) {
+        // Update view
+        savingEvent(true)
+        adapter.items.remove(event)
+        adapter.notifyDataSetChanged()
+
+        // Update data
+        setLoading(true)
+        logbook.logs.remove(event)
+        saveLogbook()
+    }
+
     /**
      * Saves the logbook. If saving while adding an event, please specify the event so in case
      * of error can be removed from the list.
@@ -558,6 +597,8 @@ class MainActivity : AppCompatActivity() {
                     onRepoError(
                         if(error.toString().contains("401")) {
                             getString(R.string.settings_webdav_error_denied)
+                        } else if(error.toString().contains("503")) {
+                            getString(R.string.settings_webdav_error_server_offline)
                         } else {
                             getString(R.string.settings_webdav_error_generic) + error.toString()
                         }

app/src/main/java/it/danieleverducci/lunatracker/repository/WebDAVLogbookRepository.kt

@@ -103,19 +103,32 @@ class WebDAVLogbookRepository(val webDavURL: String, val username: String, val p
         listener: LogbookListObtainedListener
     ) {
         Thread(Runnable {
-            val logbooksNames = arrayListOf<String>()
-            for (dr: DavResource in sardine.list(webDavURL)){
-                if(!dr.name.startsWith(FILE_NAME_START))
-                    continue
-                if(!dr.name.endsWith(FILE_NAME_END))
-                    continue
-                logbooksNames.add(
-                    dr.name.replace("${FILE_NAME_START}_", "")
-                        .replace(FILE_NAME_START, "")
-                        .replace(FILE_NAME_END, "")
-                )
+            try {
+                val logbooksNames = arrayListOf<String>()
+                for (dr: DavResource in sardine.list(webDavURL)){
+                    if(!dr.name.startsWith(FILE_NAME_START))
+                        continue
+                    if(!dr.name.endsWith(FILE_NAME_END))
+                        continue
+                    logbooksNames.add(
+                        dr.name.replace("${FILE_NAME_START}_", "")
+                            .replace(FILE_NAME_START, "")
+                            .replace(FILE_NAME_END, "")
+                    )
+                }
+                listener.onLogbookListObtained(logbooksNames)
+            } catch (e: SardineException) {
+                Log.e(TAG, e.toString())
+                listener.onWebDAVError(e)
+            } catch (e: IOException) {
+                Log.e(TAG, e.toString())
+                listener.onIOError(e)
+            } catch (e: SocketTimeoutException) {
+                Log.e(TAG, e.toString())
+                listener.onIOError(e)
+            } catch (e: Exception) {
+                listener.onError(e)
             }
-            listener.onLogbookListObtained(logbooksNames)
         }).start()
     }
 

app/src/main/res/values-it/strings.xml

@@ -61,6 +61,7 @@
     <string name="settings_storage_dav_pass">Password</string>
     <string name="settings_network_error">Impossibile raggiungere il server: </string>
     <string name="settings_webdav_error_denied">Nome utente o password WebDAV sbagliati</string>
+    <string name="settings_webdav_error_server_offline">Il server WebDAV non è al momento disponibile</string>
     <string name="settings_webdav_error_generic">Si è verificato un errore tentando di accedere al server WebDAV:</string>
     <string name="settings_webdav_creation_error_generic">Impossibile creare un file di salvataggio sul server WebDAV:</string>
     <string name="settings_webdav_creation_ok">Connessione al server WebDAV avvenuta con successo</string>
@@ -80,11 +81,14 @@
     <string name="log_notes_dialog_note_hint">Inserisci le note</string>
 
     <string name="dialog_event_detail_title">Dettaglio evento</string>
+    <string name="dialog_event_detail_save_button">Salva</string>
+    <string name="dialog_event_detail_delete_button">Elimina</string>
 
     <string name="dialog_add_logbook_title">Aggiungi diario</string>
     <string name="dialog_add_logbook_logbookname">👶 Nome del diario</string>
     <string name="dialog_add_logbook_message">Scrivi un nome per identificare questo diario. Comparirà in cima allo schermo, e se usi WebDAV sarà incluso anche nel nome del file di salvataggio.\nSe vuoi un\'icona, inserisci una emoji!</string>
 
+    <string name="dialog_add_logbook_message_intro">Benvenuto! Per usare quest\'app devi creare almeno un diario. Probabilmente vuoi chiamarlo col nome di tuo figlio.</string>
     <string name="default_logbook_name">👶 Il mio primo diario</string>
     <string name="logbook_created">Creato nuovo diario: </string>
 

app/src/main/res/values/strings.xml

@@ -75,6 +75,7 @@
     <string name="settings_storage_dav_pass">Password</string>
     <string name="settings_network_error">Unable to reach server: </string>
     <string name="settings_webdav_error_denied">Wrong WebDAV user or password</string>
+    <string name="settings_webdav_error_server_offline">WebDAV server is currently unavailable</string>
     <string name="settings_webdav_error_generic">Error while trying to access WebDAV:</string>
     <string name="settings_webdav_creation_error_generic">Unable to save a file on the WebDAV server:</string>
     <string name="settings_webdav_creation_ok">Successfully connected with WebDAV server</string>
@@ -103,6 +104,8 @@
     <string name="measurement_unit_temperature_base_metric" translatable="false">°C</string>
 
     <string name="dialog_event_detail_title">Event detail</string>
+    <string name="dialog_event_detail_save_button">Save</string>
+    <string name="dialog_event_detail_delete_button">Delete</string>
 
     <string name="dialog_add_logbook_title">Add logbook</string>
     <string name="dialog_add_logbook_logbookname">👶 Logbook name</string>