penguin86/luna-tracker
2
2
Fork 2
Code Issues 12 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

improvements #10

Merged
penguin86 merged 17 commits from mwarning/luna-tracker:improvements into master 2025-09-21 09:01:03 +02:00
Conversation 3 Commits 17 Files Changed 17 +377 -162
mwarning commented 2025-09-16 09:54:28 +02:00
Contributor
Copy Link

A bunch of several improvements.

Features:

  • add "no breastfeeding" setting to hide the breast feeding buttons (some women do not breastfeed, showing those options every time can be unnerving)
  • suppoort for 24h date picker
  • add view toggle eye for the webdav password field (makes it easiert to share the password)
  • add previous/next links to the event detail dialog (allows to see how long ago the previous mils was gives etc.)

Layout changes:

  • remove "Log event" title (saves some vertical space)
  • put connection progress bar to the right of "Logged events" title (saves some vertical space)
  • increase font size in event details dialog
  • remove stray character in time format string

Code cleanup:

  • make more strings translatable
  • replace deprecated / discouraged layout options (dp to sp, layoutMarginLeft to layoutMarginStart, ..)
  • remove unnecessary code
  • escape aprosthrophe in translations (Android Studio refuses to build it otherwise)
A bunch of several improvements. Features: * add "no breastfeeding" setting to hide the breast feeding buttons (some women do not breastfeed, showing those options every time can be unnerving) * suppoort for 24h date picker * add view toggle eye for the webdav password field (makes it easiert to share the password) * add previous/next links to the event detail dialog (allows to see how long ago the previous mils was gives etc.) Layout changes: * remove "Log event" title (saves some vertical space) * put connection progress bar to the right of "Logged events" title (saves some vertical space) * increase font size in event details dialog * remove stray character in time format string Code cleanup: * make more strings translatable * replace deprecated / discouraged layout options (dp to sp, layoutMarginLeft to layoutMarginStart, ..) * remove unnecessary code * escape aprosthrophe in translations (Android Studio refuses to build it otherwise)
mwarning added 16 commits 2025-09-16 09:54:29 +02:00
layout_marginLeft is deprecated 674d4fd744
add password toggle view icon 1508db2a56
values: escape apostrophe characters 3a65d09e58
replace dp with sp 9efe2a3574 
As suggested by android-studio.
add setting to disable breastfeeding buttons 77f6a89fcc 
Some women do not breastfeed. Hide the buttons
in order to have more space for log messages.
remove log event title e566624a29 
Keep the main page simpler and have a bit more
space for log messages.
bigger font for event detail dialog 63a8dde6c5
MainActivity: small code cleanup 15a9fab5f5
MainActivity: support 24h format baea313cbb
activity_main: move progress bar next to event list title 2580bc882a 
Save some vertical space and prevent vertical size change/flicker.
remove stray 1 character from time d57cd8b166
remove unused imports e987d9cd40
make some val constant 5797159f8f
make more strings translateable 999ab96d9d
add previous/next event link to details dialog 5d2ba2e3f5 
The links will point to the previous/next
event of the same type
DateUtils: simplify code 62d2f9deb4
mwarning force-pushed improvements from 62d2f9deb4 to b389197fb1 2025-09-16 21:14:00 +02:00 Compare
mwarning added 1 commit 2025-09-16 21:36:15 +02:00
prevent stuffed lines if the font is magnified f92d27db28
mwarning force-pushed improvements from f92d27db28 to b389197fb1 2025-09-17 12:40:18 +02:00 Compare
mwarning force-pushed improvements from b389197fb1 to 897b7bcf93 2025-09-17 12:42:48 +02:00 Compare
mwarning force-pushed improvements from 897b7bcf93 to 5df3b31e64 2025-09-19 12:42:14 +02:00 Compare
penguin86 commented 2025-09-21 09:00:52 +02:00
Owner
Copy Link

Hello @mwarning , thank you for the contribution! You've done a lot of work and it's very organized and easy to review.
It seems all perfect to me except for a part of the replace dp with sp commit, because the textviews in activity_main.xml containing emojis are used as images, so they should stay at the same size independently of the system font scale settings. No need to change the commit, btw, I'll going to merge this pull request and change it only where needed.
Thank you a lot!

Hello @mwarning , thank you for the contribution! You've done a lot of work and it's very organized and easy to review. It seems all perfect to me except for a part of the `replace dp with sp` commit, because the textviews in `activity_main.xml` containing emojis are used as images, so they should stay at the same size independently of the system font scale settings. No need to change the commit, btw, I'll going to merge this pull request and change it only where needed. Thank you a lot!
penguin86 merged commit d4adb9d981 into master 2025-09-21 09:01:03 +02:00
penguin86 commented 2025-09-21 09:02:59 +02:00
Owner
Copy Link

PS: for the next time it's better to create a PR on the develop branch, so that if there's a version already in publishing, the PR can be merged anyway and published later. Thank you!

PS: for the next time it's better to create a PR on the develop branch, so that if there's a version already in publishing, the PR can be merged anyway and published later. Thank you!
mwarning commented 2025-09-21 09:43:32 +02:00
Author
Contributor
Copy Link

hi @penguin86, thanks a lot for merging. I went with the dp/sp change because android studio suggested it.
Next time I will target the development branch. :)

hi @penguin86, thanks a lot for merging. I went with the dp/sp change because android studio suggested it. Next time I will target the development branch. :)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
penguin86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: penguin86/luna-tracker#10
No description provided.
Delete Branch "mwarning/luna-tracker:improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?