penguin86/luna-tracker
2
2
Fork 2
Code Issues 12 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix puke event quantity #18

Merged
penguin86 merged 1 commits from mwarning/luna-tracker:fixpuke into master 2025-11-06 22:17:40 +01:00
Conversation 4 Commits 1 Files Changed 2 +2 -2
mwarning commented 2025-11-06 21:48:34 +01:00
Contributor
Copy Link

The LunaEvent class treats quantities of 0
as a value to set. To workaround this, the
quantity index needs to start at >0.

The LunaEvent class treats quantities of 0 as a value to set. To workaround this, the quantity index needs to start at >0.
mwarning added 1 commit 2025-11-06 21:48:34 +01:00
fix puke event quantitiy bb32208f36 
The LunaEvent class treats quantities of 0
as a value to set. To workaround this, the
quantity index needs to start at >0.
mwarning commented 2025-11-06 21:49:14 +01:00
Author
Contributor
Copy Link

This is the simplest fix for this issue. Not very elegant though.

This is the simplest fix for this issue. Not very elegant though.
mwarning force-pushed fixpuke from bb32208f36 to 6f3061974d 2025-11-06 21:52:23 +01:00 Compare
mwarning commented 2025-11-06 21:53:29 +01:00
Author
Contributor
Copy Link

@penguin86 it would be nice to get this merged before any release. Otherwise it will corrupt the data of this event and lead to a crash.

@penguin86 it would be nice to get this merged before any release. Otherwise it will corrupt the data of this event and lead to a crash.
penguin86 merged commit 5b777c0b88 into master 2025-11-06 22:17:40 +01:00
penguin86 commented 2025-11-06 22:18:15 +01:00
Owner
Copy Link

I already tagged the commit when I accepted the previous PR, so it may have already been picked up by the F-Droid build pipeline. I'll send this one too and see if it makes in time.

I already tagged the commit when I accepted the previous PR, so it may have already been picked up by the F-Droid build pipeline. I'll send this one too and see if it makes in time.
mwarning commented 2025-11-07 21:40:21 +01:00
Author
Contributor
Copy Link

@penguin86 Thank you for merging. 0.8 has been already picked up by f-droid, but has not yet been build.. But with some luck 0.9 will shadow 0.8.

@penguin86 Thank you for merging. 0.8 has been already picked up by f-droid, but has not yet been build.. But with some luck 0.9 will shadow 0.8.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
penguin86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: penguin86/luna-tracker#18
No description provided.
Delete Branch "mwarning/luna-tracker:fixpuke"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?